Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doris-sink): fix json type and use the FE host instead when the BE host is set to localhost #16018

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

xuefengze
Copy link
Contributor

@xuefengze xuefengze commented Mar 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #15978

If Doris FE and BE are on the same machine, the BE's address can be set to 127.0.0.1. However, RW might not be able to connect to it, so use the FE's host instead of the BE's host.
e.g.
In the e2e-doris-sink test, BE's origin address is 127.0.0.1:8040, after replace with FE host, it is doris-server:8040.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xuefengze xuefengze requested a review from xxhZs April 1, 2024 02:04
Copy link
Contributor

@xxhZs xxhZs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If it's been tested and there's no problem

@xuefengze xuefengze added this pull request to the merge queue Apr 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2024
@xuefengze xuefengze added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 49a575e Apr 3, 2024
30 of 31 checks passed
@xuefengze xuefengze deleted the fz/fix_doris_sink_json branch April 3, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doris-sink: doris type is "JSON" risingwave type is Jsonb
2 participants